[llvm] [LAA] Fix incorrect dependency classification. (PR #70819)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 23 14:14:18 PST 2023


fhahn wrote:

Thanks for rebasing on top of the test changes, good to see that's fixed now as well! I pushed a commit factoring out the logic to compute the distance, stride & co to a helper function in 96452676e534c70a652ffdf260ee849290f374c4. This limits the scope of the swapped variables and makes it easier to see why not swapping them is fine.

Would be good to rebase on top of that again and update the description of the PR with a more precise explanation of why IsWrite should not be swapped: their users rely on program order. Would still be good to retain the original printing order.

After 96452676e534c70a652ffdf260ee849290f374c4, retrieving and checking `IsWrite` can be easily be moved out of the helper, as it is independent of computing the distance/stride.


https://github.com/llvm/llvm-project/pull/70819


More information about the llvm-commits mailing list