dwblaikie wrote: Does this need test coverage? Or is the assert essentially adding test coverage? (eg: would adding the assert have fired at ToT without the other changes?) https://github.com/llvm/llvm-project/pull/73148