[libcxx] [llvm] [libc++] Remove the ignore_format.txt file (PR #73135)
Louis Dionne via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 22 08:28:36 PST 2023
================
@@ -115,24 +115,12 @@ class ClangFormatHelper(FormatHelper):
def instructions(self) -> str:
return " ".join(self.cf_cmd)
- @cached_property
- def libcxx_excluded_files(self) -> list[str]:
- with open("libcxx/utils/data/ignore_format.txt", "r") as ifd:
- return [excl.strip() for excl in ifd.readlines()]
-
- def should_be_excluded(self, path: str) -> bool:
- if path in self.libcxx_excluded_files:
- print(f"{self.name}: Excluding file {path}")
- return True
- return False
-
def filter_changed_files(self, changed_files: list[str]) -> list[str]:
filtered_files = []
for path in changed_files:
_, ext = os.path.splitext(path)
if ext in (".cpp", ".c", ".h", ".hpp", ".hxx", ".cxx"):
- if not self.should_be_excluded(path):
- filtered_files.append(path)
+ filtered_files.append(path)
----------------
ldionne wrote:
@tru Did we ever implement the changes so that the `clang-format` job would run on extension-less headers in libc++? If not, this means that we actually *haven't* been running the `clang-format` checking on headers like `__config`, which would explain a whole lot of the confusion we've been having.
Reading through the code, I think the answer is "no, it slipped through the cracks and was never implemented".
https://github.com/llvm/llvm-project/pull/73135
More information about the llvm-commits
mailing list