[mlir] [llvm] [CI] Add check-mlir-python to MLIR pre-merge checks (PR #72847)

via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 22 05:23:07 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-sme

Author: Benjamin Maxwell (MacDue)

<details>
<summary>Changes</summary>

PR for: https://discourse.llvm.org/t/add-check-mlir-python-to-the-mlir-pre-commit-tests/74041

It’s easy to forget about the Python bindings and not build/test them locally. It’s also easy to change something that’ll break the python binding tests and not find out till after you’ve committed your change.

These tests seem to run quickly and don’t require much extra setup, so let's add them to the general MLIR pre-merge tests.

---
Full diff: https://github.com/llvm/llvm-project/pull/72847.diff


3 Files Affected:

- (modified) .ci/monolithic-linux.sh (+2-1) 
- (modified) .ci/monolithic-windows.sh (+2-1) 
- (modified) mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td (+1) 


``````````diff
diff --git a/.ci/monolithic-linux.sh b/.ci/monolithic-linux.sh
index 311488b2c2878b1..f0577d1069d5dec 100755
--- a/.ci/monolithic-linux.sh
+++ b/.ci/monolithic-linux.sh
@@ -49,7 +49,8 @@ cmake -S ${MONOREPO_ROOT}/llvm -B ${BUILD_DIR} \
       -D LLVM_ENABLE_LLD=ON \
       -D CMAKE_CXX_FLAGS=-gmlt \
       -D BOLT_CLANG_EXE=/usr/bin/clang \
-      -D LLVM_CCACHE_BUILD=ON
+      -D LLVM_CCACHE_BUILD=ON \
+      -D MLIR_ENABLE_BINDINGS_PYTHON=ON
 
 echo "--- ninja"
 # Targets are not escaped as they are passed as separate arguments.
diff --git a/.ci/monolithic-windows.sh b/.ci/monolithic-windows.sh
index 00c3037c4c4fd61..7ac806a0b399ad5 100755
--- a/.ci/monolithic-windows.sh
+++ b/.ci/monolithic-windows.sh
@@ -48,7 +48,8 @@ cmake -S ${MONOREPO_ROOT}/llvm -B ${BUILD_DIR} \
       -D LLVM_LIT_ARGS="-v --xunit-xml-output ${BUILD_DIR}/test-results.xml" \
       -D COMPILER_RT_BUILD_ORC=OFF \
       -D CMAKE_C_COMPILER_LAUNCHER=sccache \
-      -D CMAKE_CXX_COMPILER_LAUNCHER=sccache
+      -D CMAKE_CXX_COMPILER_LAUNCHER=sccache \
+      -D MLIR_ENABLE_BINDINGS_PYTHON=ON
 
 echo "--- ninja"
 # Targets are not escaped as they are passed as separate arguments.
diff --git a/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td b/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td
index ba33a2826e6ca4b..37b99f0738adc43 100644
--- a/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td
+++ b/mlir/include/mlir/Dialect/ArmSME/IR/ArmSMEOps.td
@@ -11,6 +11,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+// Test
 #ifndef ARMSME_OPS
 #define ARMSME_OPS
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/72847


More information about the llvm-commits mailing list