jayfoad wrote: > Tests are pre-committed, but the commit is part of this very pull request. Would that be okay? In my opinion yes, that's a good way to do it. It allows reviewers to see the test diffs in the second patch. https://github.com/llvm/llvm-project/pull/73108