[llvm] [AIX] In assembly file, create a dummy text renamed to an empty string (PR #73052)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 21 15:29:56 PST 2023
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff d82b52139a418a4c6eb6d95e553c25506988b169 7accdbed1e68c39d94b6fb852b8de2df2af793df -- llvm/include/llvm/MC/MCSectionXCOFF.h llvm/include/llvm/MC/MCSymbolXCOFF.h llvm/include/llvm/MC/MCXCOFFStreamer.h llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp llvm/lib/MC/MCObjectFileInfo.cpp llvm/lib/MC/MCStreamer.cpp llvm/lib/MC/MCXCOFFStreamer.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/include/llvm/MC/MCXCOFFStreamer.h b/llvm/include/llvm/MC/MCXCOFFStreamer.h
index 3e68c3922b..8cae64fa33 100644
--- a/llvm/include/llvm/MC/MCXCOFFStreamer.h
+++ b/llvm/include/llvm/MC/MCXCOFFStreamer.h
@@ -32,7 +32,8 @@ public:
MCSymbolAttr Linkage,
MCSymbolAttr Visibility) override;
void emitXCOFFRefDirective(const MCSymbol *Symbol) override;
- void emitXCOFFRenameDirective(const MCSymbol *Name, StringRef Rename) override;
+ void emitXCOFFRenameDirective(const MCSymbol *Name,
+ StringRef Rename) override;
void emitXCOFFExceptDirective(const MCSymbol *Symbol, const MCSymbol *Trap,
unsigned Lang, unsigned Reason,
unsigned FunctionSize, bool hasDebug) override;
diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
index 2e7e7a4b7f..3a679f1576 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -91,9 +91,9 @@
#include "llvm/MC/MCInst.h"
#include "llvm/MC/MCSection.h"
#include "llvm/MC/MCSectionCOFF.h"
-#include "llvm/MC/MCSectionXCOFF.h"
#include "llvm/MC/MCSectionELF.h"
#include "llvm/MC/MCSectionMachO.h"
+#include "llvm/MC/MCSectionXCOFF.h"
#include "llvm/MC/MCStreamer.h"
#include "llvm/MC/MCSubtargetInfo.h"
#include "llvm/MC/MCSymbol.h"
@@ -504,10 +504,10 @@ bool AsmPrinter::doInitialization(Module &M) {
// a rename for the default text-section symbol name. This call has
// no effect when generating object code directly.
MCSection *TextSection =
- OutStreamer->getContext().getObjectFileInfo()->getTextSection();
+ OutStreamer->getContext().getObjectFileInfo()->getTextSection();
MCSymbolXCOFF *XSym =
- static_cast<MCSectionXCOFF *>(TextSection)->getQualNameSymbol();
- if (XSym->hasRename())
+ static_cast<MCSectionXCOFF *>(TextSection)->getQualNameSymbol();
+ if (XSym->hasRename())
OutStreamer->emitXCOFFRenameDirective(XSym, XSym->getSymbolTableName());
}
diff --git a/llvm/lib/MC/MCStreamer.cpp b/llvm/lib/MC/MCStreamer.cpp
index 071c5abb9a..0062d08353 100644
--- a/llvm/lib/MC/MCStreamer.cpp
+++ b/llvm/lib/MC/MCStreamer.cpp
@@ -1190,7 +1190,7 @@ void MCStreamer::emitXCOFFSymbolLinkageWithVisibility(MCSymbol *Symbol,
}
void MCStreamer::emitXCOFFRenameDirective(const MCSymbol *Name,
- StringRef Rename) { }
+ StringRef Rename) {}
void MCStreamer::emitXCOFFRefDirective(const MCSymbol *Symbol) {
llvm_unreachable("emitXCOFFRefDirective is only supported on XCOFF targets");
``````````
</details>
https://github.com/llvm/llvm-project/pull/73052
More information about the llvm-commits
mailing list