[llvm] [XCOFF][obj2yaml] support parsing auxiliary symbols for XCOFF (PR #70642)

via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 21 13:55:19 PST 2023


================
@@ -146,10 +146,11 @@ Error XCOFFDumper::dumpFileAuxSym(XCOFFYAML::Symbol &Sym,
   return Error::success();
 }
 
-void XCOFFDumper::dumpStatAuxSym(XCOFFYAML::Symbol &Sym,
-                                 const XCOFFSymbolRef &SymbolEntRef) {
-  assert(Sym.NumberOfAuxEntries == 1 &&
-         "expected a single aux symbol for C_STAT!");
+Error XCOFFDumper::dumpStatAuxSym(XCOFFYAML::Symbol &Sym,
+                                  const XCOFFSymbolRef &SymbolEntRef) {
+  if (Sym.NumberOfAuxEntries != 1)
+    return createError("expected a single aux symbol for C_STAT, while got: " +
----------------
diggerlin wrote:

Suggest that we  provide more detail info for invalid Symbol (for example symbol index), let user can locate the specific invalid symbol.    

and some test case for the Error scenarion.

https://github.com/llvm/llvm-project/pull/70642


More information about the llvm-commits mailing list