[llvm] [ASan] Allow for passing AddressSanitizer command line options through the AddressSanitizerOptions struct. (PR #72439)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 21 10:51:59 PST 2023


================
@@ -644,18 +643,28 @@ namespace {
 
 /// AddressSanitizer: instrument the code in module to find memory bugs.
 struct AddressSanitizer {
-  AddressSanitizer(Module &M, const StackSafetyGlobalInfo *SSGI,
-                   bool CompileKernel = false, bool Recover = false,
-                   bool UseAfterScope = false,
-                   AsanDetectStackUseAfterReturnMode UseAfterReturn =
-                       AsanDetectStackUseAfterReturnMode::Runtime)
+  AddressSanitizer(
----------------
vitalybuka wrote:

May I ask you to remove default arguments from these constructor, including existing ones. In a separate PR is possible.

This is internal class and it's constructed just onces.
It will make code cleaner

https://github.com/llvm/llvm-project/pull/72439


More information about the llvm-commits mailing list