[PATCH] D157657: [RISCV] Support R_RISCV_SET_ULEB128/R_RISCV_SUB_ULEB128 for .uleb128 directives

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 22:50:39 PST 2023


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/include/llvm/MC/MCFragment.h:438
 
   SmallString<8> Contents;
 
----------------
craig.topper wrote:
> Should this Contents field be removed?
Thanks for 3b916ad6733b04a86ca0aec57be647daf4647d5b `[MC] Remove duplicate Contents field from MCLEBFragment.`

Another thing we can tune is the template arguments in `MCEncodedFragmentWithFixups<10, 1>`, e.g. `<8, 0>` `<8, 1>` `<10, 1>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157657/new/

https://reviews.llvm.org/D157657



More information about the llvm-commits mailing list