[lld] [LLD] dtNeeded name should consistent with soNames (PR #72857)

Longsheng Mou via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 17:36:06 PST 2023


CoTinker wrote:

> I'm finding your examples a bit hard to follow. Can you clarify a few things:
> 
> * Did you mean have.c to just be a declaration? There is no foo in the dynamic symbol.
> * What is ususe.c? Is it just use.c renamed?
> * Is -o exe/libuseo a mistake -luse won't pick that up as it looks for libuse.a or libuse.so
> * Please can you write a test for your patch? Look for examples in lld/ELF/tests

1. YES,the foo function is declared but not implemented.
2. That's my fault, I wrote it wrong.
3. No, actually in case 3, dtneeded name is exe/libhave.so, but soName is libhave.so in -lhave, so there are inconsistent. In case 4, dtneeded name is libhave.so, but soName is exe/libhave.so, alse inconsistent.
4. I'll try it.

https://github.com/llvm/llvm-project/pull/72857


More information about the llvm-commits mailing list