[llvm] Allow the dumping of .dwo files contents to show up when dumping an e… (PR #66726)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 16:01:53 PST 2023


================
@@ -751,7 +751,7 @@ void DWARFUnit::updateAddressDieMap(DWARFDie Die) {
 DWARFDie DWARFUnit::getSubroutineForAddress(uint64_t Address) {
   extractDIEsIfNeeded(false);
   if (AddrDieMap.empty())
-    updateAddressDieMap(getUnitDIE());
+    updateAddressDieMap(getNonSkeletonUnitDIE(/*ExtractUnitDIEOnly=*/false));
----------------
dwblaikie wrote:

this seems interesting - what motivates this change/could it be separated from the basic "dump the non-dwos" stuff? (`getNonSkeletonUnitDIE` unconditionally could cause a lot more DWARF parsing/trying to read all the DIES in non-skeleton units too when they weren't being read before this patch?)

https://github.com/llvm/llvm-project/pull/66726


More information about the llvm-commits mailing list