[llvm] Solve llvm-dwp overflow problem, skipped over 4GB '.dwo' files (PR #71902)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 12:30:38 PST 2023


================
@@ -201,7 +201,8 @@ static Error addAllTypesFromDWP(
     MCStreamer &Out, MapVector<uint64_t, UnitIndexEntry> &TypeIndexEntries,
     const DWARFUnitIndex &TUIndex, MCSection *OutputTypes, StringRef Types,
     const UnitIndexEntry &TUEntry, uint32_t &TypesOffset,
-    unsigned TypesContributionIndex, bool ContinueOnCuIndexOverflow) {
+    unsigned TypesContributionIndex, bool ContinueOnCuIndexOverflow,
+    bool &SeeOverflowFlag, bool SoftStopOnCuIndexOverflow) {
----------------
dwblaikie wrote:

Perhaps we could combine the `ContinueOnCuIndexOverflow` and `SoftStopOnCuIndexOverflow` into an enum `OnCuIndexOverflow` with values `HardStop`, `SoftStop`, and `Continue`? (`HardStop` being the default)

https://github.com/llvm/llvm-project/pull/71902


More information about the llvm-commits mailing list