[mlir] [llvm] [flang] Make MLIR Value more consistent in terms of `const` "correctness" (NFC) (PR #72765)

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 12:00:45 PST 2023


================
@@ -335,8 +335,9 @@ namespace llvm {
     MutableArrayRef(T *begin, T *end) : ArrayRef<T>(begin, end) {}
 
     /// Construct a MutableArrayRef from a SmallVector.
-    /*implicit*/ MutableArrayRef(SmallVectorImpl<T> &Vec)
-    : ArrayRef<T>(Vec) {}
+    template <typename U>
+    /*implicit*/ MutableArrayRef(const SmallVectorTemplateCommon<T, U> &Vec)
+        : ArrayRef<T>(Vec) {}
----------------
joker-eph wrote:

Actually I don't need this change anymore, since I moved off of using MutableArrayRef.

Are we writing unit-test for NFC changes? Seems a bit overkill to me.

https://github.com/llvm/llvm-project/pull/72765


More information about the llvm-commits mailing list