[llvm] [LAA] Fix incorrect dependency classification. (PR #70819)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 20 03:27:31 PST 2023


https://github.com/fhahn commented:

Thanks for the update.

I had a closer look at all uses of the swapped values, and the swapping is only needed for the printing. The other uses all check that they are the same, except for the `IsWrite`.

But for those all uses expect them in program order, so not swapping them makes sense.

I added another test in 5d353423c97517ae1dc66506186e265538b0111f that is a variant of. the current test case that shows how we currently also incorrectly indentify a dependence that prevents forwarding as forward only (the commit also auto-generates the checks and cleans up the value names a bit).

Could you rebase and check if the test now also gets handled correctly?

https://github.com/llvm/llvm-project/pull/70819


More information about the llvm-commits mailing list