[llvm] [mlir] Make MLIR Value more consistent in terms of `const` "correctness" (NFC) (PR #72765)
    Oleksandr Alex Zinenko via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Nov 20 00:30:44 PST 2023
    
    
  
================
@@ -91,7 +91,7 @@ struct ToyInlinerInterface : public DialectInlinerInterface {
   /// previously returned by the call operation with the operands of the
   /// return.
   void handleTerminator(Operation *op,
-                        ArrayRef<Value> valuesToRepl) const final {
+                        MutableArrayRef<Value> valuesToRepl) const final {
----------------
ftynse wrote:
Should we just use `ValueRange` everywhere instead of `(Mubtale)ArrayRef<Value>`? The former seems to always return `Value` by value and avoid const-reference annoyance?
https://github.com/llvm/llvm-project/pull/72765
    
    
More information about the llvm-commits
mailing list