[llvm] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70515)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 17 15:21:18 PST 2023


MaskRay wrote:

> Eh, like on Phab, I think it's handy to be able to see the incremental progress of the review. If someone's already reviewed a patch, they might benefit from being able to see the differences only from the last update to the previous, rather than the whole thing. Giving the steps names/descriptions is helpful too, helps to know what to look for in the changes, etc.

https://discourse.llvm.org/t/force-push-and-rebase/73766/13

I think the foremost problem of GitHub UI is that the "compare button" is not that useful for a rebase-to-upstream workflow. If you amend commits without rebase, the "compare button" is good. But in cases when you merge upstream changes into the branch, the adjustment in the merge commit itself is also not good.

In any case, making a comment after an update will be useful.

https://github.com/llvm/llvm-project/pull/70515


More information about the llvm-commits mailing list