[PATCH] D156882: [AArch64][ELF][lld] Support AUTH relocations and AUTH ELF marking

[Daniil Kovalev via Phabricator via llvm-commits]

kovdan01 added a comment.

@MaskRay Resolved the issues mentioned and moved the patch to https://github.com/llvm/llvm-project/pull/72714. Please consider reviewing it there. Thanks!



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2072
       DynRelRegion.Size = Dyn.getVal();
       DynRelRegion.SizePrintName = "DT_RELSZ value";
       break;
----------------
MaskRay wrote:
> These llvm-readobj changes should be moved to D158574
Done


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2087
       DynRelrRegion.Size = Dyn.getVal();
-      DynRelrRegion.SizePrintName = Dyn.d_tag == ELF::DT_RELRSZ
-                                        ? "DT_RELRSZ value"
-                                        : "DT_ANDROID_RELRSZ value";
+      DynRelrRegion.SizePrintName = [&Dyn]() {
+        switch (Dyn.d_tag) {
----------------
MaskRay wrote:
> immediately invoked function expression
Switched to if else if


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2103
       DynRelrRegion.EntSize = Dyn.getVal();
-      DynRelrRegion.EntSizePrintName = Dyn.d_tag == ELF::DT_RELRENT
-                                           ? "DT_RELRENT value"
-                                           : "DT_ANDROID_RELRENT value";
+      DynRelrRegion.EntSizePrintName = [&Dyn]() {
+        switch (Dyn.d_tag) {
----------------
MaskRay wrote:
> `if else if ...` is better than immediately invoked function expression here
Fixed


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6233
   case ELF::SHT_RELR:
+  case ELF::SHT_AARCH64_AUTH_RELR:
   case ELF::SHT_ANDROID_RELR: {
----------------
MaskRay wrote:
> processor-specific constants need to check isAArch64.
Added a warning, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156882/new/

https://reviews.llvm.org/D156882