[PATCH] D155245: [MC][AsmParser] Diagnose improperly nested .cfi frames

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

this is breaking runtimes builds of aarch64 builtins, e.g.

  [294/404] Building ASM object CMakeFiles\clang_rt.builtins-aarch64.dir\outline_atomic_helpers.dir\outline_atomic_cas16_1.S.obj
  FAILED: CMakeFiles/clang_rt.builtins-aarch64.dir/outline_atomic_helpers.dir/outline_atomic_cas16_1.S.obj 
  C:\b\s\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\.\bin\clang-cl.exe -target aarch64-pc-windows-msvc  /nologo -DHAS_ASM_LSE -DL_cas -DMODEL=1 -DSIZE=16 -IC:\b\s\w\ir\cache\builder\src\third_party\llvm\compiler-rt\lib\builtins -fno-lto /Zl -fno-builtin -DCOMPILER_RT_HAS_FLOAT16 /showIncludes /FoCMakeFiles\clang_rt.builtins-aarch64.dir\outline_atomic_helpers.dir\outline_atomic_cas16_1.S.obj /FdCMakeFiles\clang_rt.builtins-aarch64.dir\clang_rt.builtins-aarch64.pdb -c -- C:\b\s\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\runtimes\builtins-aarch64-pc-windows-msvc-bins\outline_atomic_helpers.dir\outline_atomic_cas16_1.S
  C:\\b\\s\\w\\ir\\cache\\builder\\src\\third_party\\llvm-build\\Release+Asserts\\runtimes\\builtins-aarch64-pc-windows-msvc-bins\\outline_atomic_helpers.dir\\outline_atomic_cas16_1.S:145:131: error: non-private labels cannot appear between .cfi_startproc / .cfi_endproc pairs
   .text ; .balign 16 ; .globl __aarch64_cas16_relax ; .def __aarch64_cas16_relax ; .scl 2 ; .type 32 ; .endef ; ; .cfi_startproc ; __aarch64_cas16_relax: ;
                                                                                                                                    ^
  C:\\b\\s\\w\\ir\\cache\\builder\\src\\third_party\\llvm-build\\Release+Asserts\\runtimes\\builtins-aarch64-pc-windows-msvc-bins\\outline_atomic_helpers.dir\\outline_atomic_cas16_1.S:145:114: error: previous .cfi_startproc was here
   .text ; .balign 16 ; .globl __aarch64_cas16_relax ; .def __aarch64_cas16_relax ; .scl 2 ; .type 32 ; .endef ; ; .cfi_startproc ; __aarch64_cas16_relax: ;

this is at https://github.com/llvm/llvm-project/blob/6a126e279dedc9fb8c204d29cfc227b0652ffe6c/compiler-rt/lib/builtins/aarch64/lse.S#L145 (need to follow a bunch of macros). the builtins should be cleaned up first before landing this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155245/new/

https://reviews.llvm.org/D155245