[llvm] [CFI] Fix Direct Call Issues in CFI Dispatch Table (PR #69663)

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 13:18:43 PST 2023


================
@@ -1471,6 +1471,11 @@ void LowerTypeTestsModule::createJumpTable(
   SmallVector<Value *, 16> AsmArgs;
   AsmArgs.reserve(Functions.size() * 2);
 
+  // Check if the first entry has the NoUnwind attribute.
----------------
efriedma-quic wrote:

re: checking only the first entry, please consider the semantics in general, not just the specific optimizations which exist at the moment.  Even if we don't optimize tables with multiple entries at the moment, someone could try to implement such an optimization in the future.

https://github.com/llvm/llvm-project/pull/69663


More information about the llvm-commits mailing list