[llvm] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70515)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 09:50:12 PST 2023


dwblaikie wrote:

> (As we now need [fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup!], I guess it should be fine to just squash them and rebase (this patch doesn't apply on main now)

Not sure I follow - certainly before it's pushed it should be squashed, but during review I think we're still encouraging folks to push additional fixup commits to make it easy to see how different feedback has been addressed & I think it lowers the risk of previous comments going missing. ( https://llvm.org/docs/GitHub.html#updating-pull-requests )

https://github.com/llvm/llvm-project/pull/70515


More information about the llvm-commits mailing list