[llvm] [CFI] Fix Direct Call Issues in CFI Dispatch Table (PR #69663)

Simon Tatham via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 01:02:21 PST 2023


statham-arm wrote:

Sorry – I'm confused. You've apparently requested that I review the change again, but it still seems to be in the same state as last time?

There's some code that looks at only the first element of a jump table, and doesn't explain why, and I think it should either check the whole table or have a comment explaining why it doesn't need to. In its current state, it's confusing to readers.

https://github.com/llvm/llvm-project/pull/69663


More information about the llvm-commits mailing list