[llvm] [AMDGPU] New AMDGPUInsertSingleUseVDST pass (PR #72388)

Carl Ritson via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 16 00:48:44 PST 2023


https://github.com/perlfu commented:

I am unsure about the test coverage here because there are barely any tests covering wide registers or subregister access.
Based on the TODO comment about MCRegUnits I guess these may not work correctly yet?
Even so it might be good to have tests that show what doesn't work, so that future patches can demonstrate improvements.

I although think many of the liveins for blocks in the test can be shorten or removed.
I have annotate a few as examples.

https://github.com/llvm/llvm-project/pull/72388


More information about the llvm-commits mailing list