[llvm] [RISCV] Omit "@plt" in assembler output "call foo at plt" (PR #72467)

Michael Maitland via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 19:37:38 PST 2023


================
@@ -2042,9 +2042,8 @@ ParseStatus RISCVAsmParser::parseCallSymbol(OperandVector &Operands) {
 
   SMLoc E = SMLoc::getFromPointer(S.getPointer() + Identifier.size());
 
-  RISCVMCExpr::VariantKind Kind = RISCVMCExpr::VK_RISCV_CALL;
-  if (Identifier.consume_back("@plt"))
-    Kind = RISCVMCExpr::VK_RISCV_CALL_PLT;
+  RISCVMCExpr::VariantKind Kind = RISCVMCExpr::VK_RISCV_CALL_PLT;
----------------
michaelmaitland wrote:

Should we ditch VK_RISCV_CALL and only have a VK_RISCV_CALL_PLT? The ABI decided to keep R_RISCV_CALL_PLT not R_RISCV_CALL. It may be more clear to be analogous to the ABI and since we want to always emit the @plt suffix. 

https://github.com/llvm/llvm-project/pull/72467


More information about the llvm-commits mailing list