[llvm] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70515)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 16:53:42 PST 2023


================
@@ -305,14 +305,17 @@ void Loc::MMI::addFrameIndexExpr(const DIExpression *Expr, int FI) {
 
 static AccelTableKind computeAccelTableKind(unsigned DwarfVersion,
                                             bool GenerateTypeUnits,
+                                            bool HasSplitDwarf,
                                             DebuggerKind Tuning,
                                             const Triple &TT) {
   // Honor an explicit request.
   if (AccelTables != AccelTableKind::Default)
     return AccelTables;
 
-  // Accelerator tables with type units are currently not supported.
-  if (GenerateTypeUnits)
+  // Generating DWARF5 acceleration table.
+  // Currently Split dwarf and non ELF format is not supported.
----------------
dwblaikie wrote:

I think we only need to check GenerateTypeUnits !SplitDWARF - the MachO/apple_names case is handled earlier/we don't enable type units in that case at all. And DWARFv5 or greater is the only case that can have debug_names anyway.

https://github.com/llvm/llvm-project/pull/70515


More information about the llvm-commits mailing list