[compiler-rt] [builtins][test] Don't XFAIL divtc3_test.c on 32-bit Solaris/sparc fo… (PR #72403)

Rainer Orth via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 15 07:16:47 PST 2023


https://github.com/rorth created https://github.com/llvm/llvm-project/pull/72403

As detailed in Issue #72398, the recent builtins rework and 77d75dc9be5c4bb1d9986a475e1c661718067c6a caused `Builtins-sparc-sunos:: divtc3_test.c` to `XPASS` on 32-bit Solaris/SPARC.  Since there are several underlying issues, un-`XFAIL` the test for now until those are resolved, to turn the Solaris/sparcv9 buildbot green again after 5 days.

Tested on `sparcv9-sun-solaris2.11` and `x86_64-pc-linux-gnu`.

>From 47a345d6c4056f8ebb29a05cbe4fe79c5e4efd64 Mon Sep 17 00:00:00 2001
From: Rainer Orth <ro at gcc.gnu.org>
Date: Wed, 15 Nov 2023 16:11:43 +0100
Subject: [PATCH] [builtins][test] Don't XFAIL divtc3_test.c on 32-bit
 Solaris/sparc for now

As detailed in Issue #72398, the recent builtins rework and
77d75dc9be5c4bb1d9986a475e1c661718067c6a caused `Builtins-sparc-sunos:: divtc3_test.c`
to `XPASS` on 32-bit Solaris/SPARC.  Since there are several underlying issues,
un-XFAIL the test for now until those are resolved, to turn the Solaris/sparcv9
buildbot green again after 5 days.
---
 compiler-rt/test/builtins/Unit/divtc3_test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/compiler-rt/test/builtins/Unit/divtc3_test.c b/compiler-rt/test/builtins/Unit/divtc3_test.c
index 33a7f869432f352..1e1cfae766e9af3 100644
--- a/compiler-rt/test/builtins/Unit/divtc3_test.c
+++ b/compiler-rt/test/builtins/Unit/divtc3_test.c
@@ -3,8 +3,8 @@
 // REQUIRES: c99-complex
 
 //
-// Bug 42493
-// XFAIL: sparc-target-arch
+// This test should be XFAILed on 32-bit sparc (sparc-target-arch, Issue
+// #41838), but that is currently hidden, which caused an XPASS (Issue #72398).
 //
 #include <stdio.h>
 



More information about the llvm-commits mailing list