[llvm] [mlir] Shard the public llvm-config.h in multiple files (NFC) (PR #71273)

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 21:54:36 PST 2023


joker-eph wrote:

> Your initial comment referred to caching.

No: I wrote "incremental rebuild **and** caching". 

> if you apply ccache or scache, both preprocess before determining a cache collision,

Both have support for "direct mode" where preprocessing can be bypassed, the impact can be going from 7 to 11min (or 60s to 110s), see discussion here: https://github.com/llvm/llvm-zorg/pull/68#issuecomment-1807514000

> This continues to lead me to the conclusion that I'm not convinced this change provides enough benefit to justify complicating our configuration include paradigm. 

I don't see the "complicating" aspect really, but also I'm a bit annoyed by your seemingly goal shifting approach to the review and tactic of being vague and evasive on your comments to ultimately get me to waste time on experiment that were obvious. Please don't do that, this isn't productive.



https://github.com/llvm/llvm-project/pull/71273


More information about the llvm-commits mailing list