[llvm] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70515)

[David Blaikie via llvm-commits]

================
@@ -310,17 +344,19 @@ void emitAppleAccelTable(AsmPrinter *Asm, AccelTable<DataT> &Contents,
 
 void emitDWARF5AccelTable(AsmPrinter *Asm, DWARF5AccelTable &Contents,
                           const DwarfDebug &DD,
-                          ArrayRef<std::unique_ptr<DwarfCompileUnit>> CUs);
-
+                          ArrayRef<std::unique_ptr<DwarfCompileUnit>> CUs,
+                          TUVectorTy TUSymbols);
+using GetIndexForEntryReturnType =
----------------
dwblaikie wrote:

I think it's few enough places, and more readable as `std::optional<DWARF5AccelTableEntry>` that that's probably the right choice. Overuse of typedefs can make code harder to read/understand/work with. If we remove the optionality/change it to some other mechanism in the future, I think it'll benefit readers to know it isn't optional and whatever else it is when we change it.

https://github.com/llvm/llvm-project/pull/70515