[llvm] [llvm-objdump] Fix lma display issue for non-bss sections (PR #72141)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 14 00:46:22 PST 2023


================
@@ -425,6 +425,8 @@ class ELFFile {
       std::function<Expected<bool>(const Elf_Shdr &)> IsMatch) const;
 
   void createFakeSections();
+
+  static bool isSectionInSegment(const Elf_Phdr &Phdr, const Elf_Shdr &Sec);
----------------
jh7370 wrote:

Minor point: I'm not sure what the benefit is of making this a static function versus a non-member function, given it takes Elf_* types, so is clearly ELF-related.

https://github.com/llvm/llvm-project/pull/72141


More information about the llvm-commits mailing list