[llvm] [DebugInfo] Make DIArgList inherit from Metadata and always unique (PR #72147)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 13 17:17:11 PST 2023


dwblaikie wrote:

> My previous comment still applies: the description should describe the choice of UINT32_MAX and UINT64_MAX, so that a curious reader doesn't have to read several external links to understand the choice.

Is there a way we could avoid hardcoding this, and just do "max of whatever the relocation size is"? (some earlier versions of this patch had switches over relocation types to try to do this - which seemed a bit verbose/brittle/repetitive - but if there was some way to generalize it tidily, I think that'd be ideal)

https://github.com/llvm/llvm-project/pull/72147


More information about the llvm-commits mailing list