[llvm] [X86][MC] Support decoding of EGPR for APX (PR #72102)

via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 13 03:08:49 PST 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff a604c4b562e99470e397f050f1e8707f923ebed7 dc6033ccf236e8337453f5b3e2e5983e832faf2c -- llvm/lib/Target/X86/Disassembler/X86Disassembler.cpp llvm/lib/Target/X86/Disassembler/X86DisassemblerDecoder.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/X86/Disassembler/X86DisassemblerDecoder.h b/llvm/lib/Target/X86/Disassembler/X86DisassemblerDecoder.h
index afbe5c3896..dcbe428aff 100644
--- a/llvm/lib/Target/X86/Disassembler/X86DisassemblerDecoder.h
+++ b/llvm/lib/Target/X86/Disassembler/X86DisassemblerDecoder.h
@@ -33,24 +33,24 @@ namespace X86Disassembler {
 #define xFromREX(rex)        (((rex) & 0x2) >> 1)
 #define bFromREX(rex)        ((rex) & 0x1)
 
-#define mFromREX2(rex2)        (((rex2) >> 7) & 0x1)
-#define r2FromREX2(rex2)       (((rex2) >> 6) & 0x1)
-#define x2FromREX2(rex2)       (((rex2) >> 5) & 0x1)
-#define b2FromREX2(rex2)       (((rex2) >> 4) & 0x1)
-#define wFromREX2(rex2)        (((rex2) >> 3) & 0x1)
-#define rFromREX2(rex2)        (((rex2) >> 2) & 0x1)
-#define xFromREX2(rex2)        (((rex2) >> 1) & 0x1)
-#define bFromREX2(rex2)        ((rex2) & 0x1)
+#define mFromREX2(rex2) (((rex2) >> 7) & 0x1)
+#define r2FromREX2(rex2) (((rex2) >> 6) & 0x1)
+#define x2FromREX2(rex2) (((rex2) >> 5) & 0x1)
+#define b2FromREX2(rex2) (((rex2) >> 4) & 0x1)
+#define wFromREX2(rex2) (((rex2) >> 3) & 0x1)
+#define rFromREX2(rex2) (((rex2) >> 2) & 0x1)
+#define xFromREX2(rex2) (((rex2) >> 1) & 0x1)
+#define bFromREX2(rex2) ((rex2) & 0x1)
 
 #define rFromEVEX2of4(evex)     (((~(evex)) & 0x80) >> 7)
 #define xFromEVEX2of4(evex)     (((~(evex)) & 0x40) >> 6)
 #define bFromEVEX2of4(evex)     (((~(evex)) & 0x20) >> 5)
 #define r2FromEVEX2of4(evex)    (((~(evex)) & 0x10) >> 4)
-#define b2FromEVEX2of4(evex)    (((evex) & 0x8) >> 3)
+#define b2FromEVEX2of4(evex) (((evex) & 0x8) >> 3)
 #define mmmFromEVEX2of4(evex)   ((evex) & 0x7)
 #define wFromEVEX3of4(evex)     (((evex) & 0x80) >> 7)
 #define vvvvFromEVEX3of4(evex)  (((~(evex)) & 0x78) >> 3)
-#define x2FromEVEX3of4(evex)    (((~(evex)) & 0x4) >> 2)
+#define x2FromEVEX3of4(evex) (((~(evex)) & 0x4) >> 2)
 #define ppFromEVEX3of4(evex)    ((evex) & 0x3)
 #define zFromEVEX4of4(evex)     (((evex) & 0x80) >> 7)
 #define l2FromEVEX4of4(evex)    (((evex) & 0x40) >> 6)
@@ -83,247 +83,246 @@ namespace X86Disassembler {
 #define ppFromXOP3of3(xop)      ((xop) & 0x3)
 
 // These enums represent Intel registers for use by the decoder.
-#define REGS_8BIT     \
-  ENTRY(AL)           \
-  ENTRY(CL)           \
-  ENTRY(DL)           \
-  ENTRY(BL)           \
-  ENTRY(AH)           \
-  ENTRY(CH)           \
-  ENTRY(DH)           \
-  ENTRY(BH)           \
-  ENTRY(R8B)          \
-  ENTRY(R9B)          \
-  ENTRY(R10B)         \
-  ENTRY(R11B)         \
-  ENTRY(R12B)         \
-  ENTRY(R13B)         \
-  ENTRY(R14B)         \
-  ENTRY(R15B)         \
-  ENTRY(R16B)         \
-  ENTRY(R17B)         \
-  ENTRY(R18B)         \
-  ENTRY(R19B)         \
-  ENTRY(R20B)         \
-  ENTRY(R21B)         \
-  ENTRY(R22B)         \
-  ENTRY(R23B)         \
-  ENTRY(R24B)         \
-  ENTRY(R25B)         \
-  ENTRY(R26B)         \
-  ENTRY(R27B)         \
-  ENTRY(R28B)         \
-  ENTRY(R29B)         \
-  ENTRY(R30B)         \
-  ENTRY(R31B)         \
-  ENTRY(SPL)          \
-  ENTRY(BPL)          \
-  ENTRY(SIL)          \
+#define REGS_8BIT                                                              \
+  ENTRY(AL)                                                                    \
+  ENTRY(CL)                                                                    \
+  ENTRY(DL)                                                                    \
+  ENTRY(BL)                                                                    \
+  ENTRY(AH)                                                                    \
+  ENTRY(CH)                                                                    \
+  ENTRY(DH)                                                                    \
+  ENTRY(BH)                                                                    \
+  ENTRY(R8B)                                                                   \
+  ENTRY(R9B)                                                                   \
+  ENTRY(R10B)                                                                  \
+  ENTRY(R11B)                                                                  \
+  ENTRY(R12B)                                                                  \
+  ENTRY(R13B)                                                                  \
+  ENTRY(R14B)                                                                  \
+  ENTRY(R15B)                                                                  \
+  ENTRY(R16B)                                                                  \
+  ENTRY(R17B)                                                                  \
+  ENTRY(R18B)                                                                  \
+  ENTRY(R19B)                                                                  \
+  ENTRY(R20B)                                                                  \
+  ENTRY(R21B)                                                                  \
+  ENTRY(R22B)                                                                  \
+  ENTRY(R23B)                                                                  \
+  ENTRY(R24B)                                                                  \
+  ENTRY(R25B)                                                                  \
+  ENTRY(R26B)                                                                  \
+  ENTRY(R27B)                                                                  \
+  ENTRY(R28B)                                                                  \
+  ENTRY(R29B)                                                                  \
+  ENTRY(R30B)                                                                  \
+  ENTRY(R31B)                                                                  \
+  ENTRY(SPL)                                                                   \
+  ENTRY(BPL)                                                                   \
+  ENTRY(SIL)                                                                   \
   ENTRY(DIL)
 
-#define EA_BASES_16BIT  \
-  ENTRY(BX_SI)          \
-  ENTRY(BX_DI)          \
-  ENTRY(BP_SI)          \
-  ENTRY(BP_DI)          \
-  ENTRY(SI)             \
-  ENTRY(DI)             \
-  ENTRY(BP)             \
-  ENTRY(BX)             \
-  ENTRY(R8W)            \
-  ENTRY(R9W)            \
-  ENTRY(R10W)           \
-  ENTRY(R11W)           \
-  ENTRY(R12W)           \
-  ENTRY(R13W)           \
-  ENTRY(R14W)           \
-  ENTRY(R15W)           \
-  ENTRY(R16W)           \
-  ENTRY(R17W)           \
-  ENTRY(R18W)           \
-  ENTRY(R19W)           \
-  ENTRY(R20W)           \
-  ENTRY(R21W)           \
-  ENTRY(R22W)           \
-  ENTRY(R23W)           \
-  ENTRY(R24W)           \
-  ENTRY(R25W)           \
-  ENTRY(R26W)           \
-  ENTRY(R27W)           \
-  ENTRY(R28W)           \
-  ENTRY(R29W)           \
-  ENTRY(R30W)           \
+#define EA_BASES_16BIT                                                         \
+  ENTRY(BX_SI)                                                                 \
+  ENTRY(BX_DI)                                                                 \
+  ENTRY(BP_SI)                                                                 \
+  ENTRY(BP_DI)                                                                 \
+  ENTRY(SI)                                                                    \
+  ENTRY(DI)                                                                    \
+  ENTRY(BP)                                                                    \
+  ENTRY(BX)                                                                    \
+  ENTRY(R8W)                                                                   \
+  ENTRY(R9W)                                                                   \
+  ENTRY(R10W)                                                                  \
+  ENTRY(R11W)                                                                  \
+  ENTRY(R12W)                                                                  \
+  ENTRY(R13W)                                                                  \
+  ENTRY(R14W)                                                                  \
+  ENTRY(R15W)                                                                  \
+  ENTRY(R16W)                                                                  \
+  ENTRY(R17W)                                                                  \
+  ENTRY(R18W)                                                                  \
+  ENTRY(R19W)                                                                  \
+  ENTRY(R20W)                                                                  \
+  ENTRY(R21W)                                                                  \
+  ENTRY(R22W)                                                                  \
+  ENTRY(R23W)                                                                  \
+  ENTRY(R24W)                                                                  \
+  ENTRY(R25W)                                                                  \
+  ENTRY(R26W)                                                                  \
+  ENTRY(R27W)                                                                  \
+  ENTRY(R28W)                                                                  \
+  ENTRY(R29W)                                                                  \
+  ENTRY(R30W)                                                                  \
   ENTRY(R31W)
 
-#define REGS_16BIT    \
-  ENTRY(AX)           \
-  ENTRY(CX)           \
-  ENTRY(DX)           \
-  ENTRY(BX)           \
-  ENTRY(SP)           \
-  ENTRY(BP)           \
-  ENTRY(SI)           \
-  ENTRY(DI)           \
-  ENTRY(R8W)          \
-  ENTRY(R9W)          \
-  ENTRY(R10W)         \
-  ENTRY(R11W)         \
-  ENTRY(R12W)         \
-  ENTRY(R13W)         \
-  ENTRY(R14W)         \
-  ENTRY(R15W)         \
-  ENTRY(R16W)         \
-  ENTRY(R17W)         \
-  ENTRY(R18W)         \
-  ENTRY(R19W)         \
-  ENTRY(R20W)         \
-  ENTRY(R21W)         \
-  ENTRY(R22W)         \
-  ENTRY(R23W)         \
-  ENTRY(R24W)         \
-  ENTRY(R25W)         \
-  ENTRY(R26W)         \
-  ENTRY(R27W)         \
-  ENTRY(R28W)         \
-  ENTRY(R29W)         \
-  ENTRY(R30W)         \
+#define REGS_16BIT                                                             \
+  ENTRY(AX)                                                                    \
+  ENTRY(CX)                                                                    \
+  ENTRY(DX)                                                                    \
+  ENTRY(BX)                                                                    \
+  ENTRY(SP)                                                                    \
+  ENTRY(BP)                                                                    \
+  ENTRY(SI)                                                                    \
+  ENTRY(DI)                                                                    \
+  ENTRY(R8W)                                                                   \
+  ENTRY(R9W)                                                                   \
+  ENTRY(R10W)                                                                  \
+  ENTRY(R11W)                                                                  \
+  ENTRY(R12W)                                                                  \
+  ENTRY(R13W)                                                                  \
+  ENTRY(R14W)                                                                  \
+  ENTRY(R15W)                                                                  \
+  ENTRY(R16W)                                                                  \
+  ENTRY(R17W)                                                                  \
+  ENTRY(R18W)                                                                  \
+  ENTRY(R19W)                                                                  \
+  ENTRY(R20W)                                                                  \
+  ENTRY(R21W)                                                                  \
+  ENTRY(R22W)                                                                  \
+  ENTRY(R23W)                                                                  \
+  ENTRY(R24W)                                                                  \
+  ENTRY(R25W)                                                                  \
+  ENTRY(R26W)                                                                  \
+  ENTRY(R27W)                                                                  \
+  ENTRY(R28W)                                                                  \
+  ENTRY(R29W)                                                                  \
+  ENTRY(R30W)                                                                  \
   ENTRY(R31W)
 
-#define EA_BASES_32BIT  \
-  ENTRY(EAX)            \
-  ENTRY(ECX)            \
-  ENTRY(EDX)            \
-  ENTRY(EBX)            \
-  ENTRY(sib)            \
-  ENTRY(EBP)            \
-  ENTRY(ESI)            \
-  ENTRY(EDI)            \
-  ENTRY(R8D)            \
-  ENTRY(R9D)            \
-  ENTRY(R10D)           \
-  ENTRY(R11D)           \
-  ENTRY(R12D)           \
-  ENTRY(R13D)           \
-  ENTRY(R14D)           \
-  ENTRY(R15D)           \
-  ENTRY(R16D)           \
-  ENTRY(R17D)           \
-  ENTRY(R18D)           \
-  ENTRY(R19D)           \
-  ENTRY(R20D)           \
-  ENTRY(R21D)           \
-  ENTRY(R22D)           \
-  ENTRY(R23D)           \
-  ENTRY(R24D)           \
-  ENTRY(R25D)           \
-  ENTRY(R26D)           \
-  ENTRY(R27D)           \
-  ENTRY(R28D)           \
-  ENTRY(R29D)           \
-  ENTRY(R30D)           \
+#define EA_BASES_32BIT                                                         \
+  ENTRY(EAX)                                                                   \
+  ENTRY(ECX)                                                                   \
+  ENTRY(EDX)                                                                   \
+  ENTRY(EBX)                                                                   \
+  ENTRY(sib)                                                                   \
+  ENTRY(EBP)                                                                   \
+  ENTRY(ESI)                                                                   \
+  ENTRY(EDI)                                                                   \
+  ENTRY(R8D)                                                                   \
+  ENTRY(R9D)                                                                   \
+  ENTRY(R10D)                                                                  \
+  ENTRY(R11D)                                                                  \
+  ENTRY(R12D)                                                                  \
+  ENTRY(R13D)                                                                  \
+  ENTRY(R14D)                                                                  \
+  ENTRY(R15D)                                                                  \
+  ENTRY(R16D)                                                                  \
+  ENTRY(R17D)                                                                  \
+  ENTRY(R18D)                                                                  \
+  ENTRY(R19D)                                                                  \
+  ENTRY(R20D)                                                                  \
+  ENTRY(R21D)                                                                  \
+  ENTRY(R22D)                                                                  \
+  ENTRY(R23D)                                                                  \
+  ENTRY(R24D)                                                                  \
+  ENTRY(R25D)                                                                  \
+  ENTRY(R26D)                                                                  \
+  ENTRY(R27D)                                                                  \
+  ENTRY(R28D)                                                                  \
+  ENTRY(R29D)                                                                  \
+  ENTRY(R30D)                                                                  \
   ENTRY(R31D)
 
-#define REGS_32BIT  \
-  ENTRY(EAX)        \
-  ENTRY(ECX)        \
-  ENTRY(EDX)        \
-  ENTRY(EBX)        \
-  ENTRY(ESP)        \
-  ENTRY(EBP)        \
-  ENTRY(ESI)        \
-  ENTRY(EDI)        \
-  ENTRY(R8D)        \
-  ENTRY(R9D)        \
-  ENTRY(R10D)       \
-  ENTRY(R11D)       \
-  ENTRY(R12D)       \
-  ENTRY(R13D)       \
-  ENTRY(R14D)       \
-  ENTRY(R15D)       \
-  ENTRY(R16D)       \
-  ENTRY(R17D)       \
-  ENTRY(R18D)       \
-  ENTRY(R19D)       \
-  ENTRY(R20D)       \
-  ENTRY(R21D)       \
-  ENTRY(R22D)       \
-  ENTRY(R23D)       \
-  ENTRY(R24D)       \
-  ENTRY(R25D)       \
-  ENTRY(R26D)       \
-  ENTRY(R27D)       \
-  ENTRY(R28D)       \
-  ENTRY(R29D)       \
-  ENTRY(R30D)       \
+#define REGS_32BIT                                                             \
+  ENTRY(EAX)                                                                   \
+  ENTRY(ECX)                                                                   \
+  ENTRY(EDX)                                                                   \
+  ENTRY(EBX)                                                                   \
+  ENTRY(ESP)                                                                   \
+  ENTRY(EBP)                                                                   \
+  ENTRY(ESI)                                                                   \
+  ENTRY(EDI)                                                                   \
+  ENTRY(R8D)                                                                   \
+  ENTRY(R9D)                                                                   \
+  ENTRY(R10D)                                                                  \
+  ENTRY(R11D)                                                                  \
+  ENTRY(R12D)                                                                  \
+  ENTRY(R13D)                                                                  \
+  ENTRY(R14D)                                                                  \
+  ENTRY(R15D)                                                                  \
+  ENTRY(R16D)                                                                  \
+  ENTRY(R17D)                                                                  \
+  ENTRY(R18D)                                                                  \
+  ENTRY(R19D)                                                                  \
+  ENTRY(R20D)                                                                  \
+  ENTRY(R21D)                                                                  \
+  ENTRY(R22D)                                                                  \
+  ENTRY(R23D)                                                                  \
+  ENTRY(R24D)                                                                  \
+  ENTRY(R25D)                                                                  \
+  ENTRY(R26D)                                                                  \
+  ENTRY(R27D)                                                                  \
+  ENTRY(R28D)                                                                  \
+  ENTRY(R29D)                                                                  \
+  ENTRY(R30D)                                                                  \
   ENTRY(R31D)
 
-
-#define EA_BASES_64BIT  \
-  ENTRY(RAX)            \
-  ENTRY(RCX)            \
-  ENTRY(RDX)            \
-  ENTRY(RBX)            \
-  ENTRY(sib64)          \
-  ENTRY(RBP)            \
-  ENTRY(RSI)            \
-  ENTRY(RDI)            \
-  ENTRY(R8)             \
-  ENTRY(R9)             \
-  ENTRY(R10)            \
-  ENTRY(R11)            \
-  ENTRY(R12)            \
-  ENTRY(R13)            \
-  ENTRY(R14)            \
-  ENTRY(R15)            \
-  ENTRY(R16)            \
-  ENTRY(R17)            \
-  ENTRY(R18)            \
-  ENTRY(R19)            \
-  ENTRY(R20)            \
-  ENTRY(R21)            \
-  ENTRY(R22)            \
-  ENTRY(R23)            \
-  ENTRY(R24)            \
-  ENTRY(R25)            \
-  ENTRY(R26)            \
-  ENTRY(R27)            \
-  ENTRY(R28)            \
-  ENTRY(R29)            \
-  ENTRY(R30)            \
+#define EA_BASES_64BIT                                                         \
+  ENTRY(RAX)                                                                   \
+  ENTRY(RCX)                                                                   \
+  ENTRY(RDX)                                                                   \
+  ENTRY(RBX)                                                                   \
+  ENTRY(sib64)                                                                 \
+  ENTRY(RBP)                                                                   \
+  ENTRY(RSI)                                                                   \
+  ENTRY(RDI)                                                                   \
+  ENTRY(R8)                                                                    \
+  ENTRY(R9)                                                                    \
+  ENTRY(R10)                                                                   \
+  ENTRY(R11)                                                                   \
+  ENTRY(R12)                                                                   \
+  ENTRY(R13)                                                                   \
+  ENTRY(R14)                                                                   \
+  ENTRY(R15)                                                                   \
+  ENTRY(R16)                                                                   \
+  ENTRY(R17)                                                                   \
+  ENTRY(R18)                                                                   \
+  ENTRY(R19)                                                                   \
+  ENTRY(R20)                                                                   \
+  ENTRY(R21)                                                                   \
+  ENTRY(R22)                                                                   \
+  ENTRY(R23)                                                                   \
+  ENTRY(R24)                                                                   \
+  ENTRY(R25)                                                                   \
+  ENTRY(R26)                                                                   \
+  ENTRY(R27)                                                                   \
+  ENTRY(R28)                                                                   \
+  ENTRY(R29)                                                                   \
+  ENTRY(R30)                                                                   \
   ENTRY(R31)
 
-#define REGS_64BIT  \
-  ENTRY(RAX)        \
-  ENTRY(RCX)        \
-  ENTRY(RDX)        \
-  ENTRY(RBX)        \
-  ENTRY(RSP)        \
-  ENTRY(RBP)        \
-  ENTRY(RSI)        \
-  ENTRY(RDI)        \
-  ENTRY(R8)         \
-  ENTRY(R9)         \
-  ENTRY(R10)        \
-  ENTRY(R11)        \
-  ENTRY(R12)        \
-  ENTRY(R13)        \
-  ENTRY(R14)        \
-  ENTRY(R15)        \
-  ENTRY(R16)        \
-  ENTRY(R17)        \
-  ENTRY(R18)        \
-  ENTRY(R19)        \
-  ENTRY(R20)        \
-  ENTRY(R21)        \
-  ENTRY(R22)        \
-  ENTRY(R23)        \
-  ENTRY(R24)        \
-  ENTRY(R25)        \
-  ENTRY(R26)        \
-  ENTRY(R27)        \
-  ENTRY(R28)        \
-  ENTRY(R29)        \
-  ENTRY(R30)        \
+#define REGS_64BIT                                                             \
+  ENTRY(RAX)                                                                   \
+  ENTRY(RCX)                                                                   \
+  ENTRY(RDX)                                                                   \
+  ENTRY(RBX)                                                                   \
+  ENTRY(RSP)                                                                   \
+  ENTRY(RBP)                                                                   \
+  ENTRY(RSI)                                                                   \
+  ENTRY(RDI)                                                                   \
+  ENTRY(R8)                                                                    \
+  ENTRY(R9)                                                                    \
+  ENTRY(R10)                                                                   \
+  ENTRY(R11)                                                                   \
+  ENTRY(R12)                                                                   \
+  ENTRY(R13)                                                                   \
+  ENTRY(R14)                                                                   \
+  ENTRY(R15)                                                                   \
+  ENTRY(R16)                                                                   \
+  ENTRY(R17)                                                                   \
+  ENTRY(R18)                                                                   \
+  ENTRY(R19)                                                                   \
+  ENTRY(R20)                                                                   \
+  ENTRY(R21)                                                                   \
+  ENTRY(R22)                                                                   \
+  ENTRY(R23)                                                                   \
+  ENTRY(R24)                                                                   \
+  ENTRY(R25)                                                                   \
+  ENTRY(R26)                                                                   \
+  ENTRY(R27)                                                                   \
+  ENTRY(R28)                                                                   \
+  ENTRY(R29)                                                                   \
+  ENTRY(R30)                                                                   \
   ENTRY(R31)
 
 #define REGS_MMX  \

``````````

</details>


https://github.com/llvm/llvm-project/pull/72102


More information about the llvm-commits mailing list