[llvm] [gold] Add a new `-plugin-opt` to enable `MCTargetOptions::AsmVerbose` (PR #71606)

Min-Yih Hsu via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 11:06:28 PST 2023


mshockwave wrote:

> > I see that lld enables this unconditionally:
> > https://github.com/llvm/llvm-project/blob/26ab444e88fc8fdd554e5a9381a68b7b5e63b6fd/lld/ELF/LTO.cpp#L156
> > 
> > How about just make it unconditionally true to be consistent and avoid adding another plugin option?
> 
> In which case you can just modify https://github.com/llvm/llvm-project/blob/26ab444e88fc8fdd554e5a9381a68b7b5e63b6fd/llvm/test/tools/gold/X86/emit-asm.ll slightly to check that the comments are emitted.

Yes I think this is a good idea. I've updated the PR.

https://github.com/llvm/llvm-project/pull/71606


More information about the llvm-commits mailing list