[llvm] beb121f - [Docs] Instructions for new contributors to find reviewers (#71936)

via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 10:45:25 PST 2023


Author: Pablo Antonio Martinez
Date: 2023-11-10T19:45:21+01:00
New Revision: beb121f6322be466384ffaa68b913f58862ed14c

URL: https://github.com/llvm/llvm-project/commit/beb121f6322be466384ffaa68b913f58862ed14c
DIFF: https://github.com/llvm/llvm-project/commit/beb121f6322be466384ffaa68b913f58862ed14c.diff

LOG: [Docs] Instructions for new contributors to find reviewers (#71936)

Right now, the documentation does not clarify what new contributors
should do to find potential reviewers, since new contributors don't have
write access and thus cannot select them as explained in the docs.

This patch extends the guidelines for new people, as discussed in
https://discourse.llvm.org/t/how-to-find-reviewers/74803

Added: 
    

Modified: 
    llvm/docs/Contributing.rst

Removed: 
    


################################################################################
diff  --git a/llvm/docs/Contributing.rst b/llvm/docs/Contributing.rst
index 1a218c5d700e062..055216845175248 100644
--- a/llvm/docs/Contributing.rst
+++ b/llvm/docs/Contributing.rst
@@ -98,7 +98,10 @@ To make sure the right people see your patch, please select suitable reviewers
 and add them to your patch when requesting a review. Suitable reviewers are the
 code owner (see CODE_OWNERS.txt) and other people doing work in the area your
 patch touches. Github will normally suggest some reviewers based on rules or
-people that have worked on the code before.
+people that have worked on the code before. If you are a new contributor, you
+will not be able to select reviewers in such a way, in which case you can still
+get the attention of potential reviewers by CC'ing them in a comment -- just
+ at name them.
 
 A reviewer may request changes or ask questions during the review. If you are
 uncertain on how to provide test cases, documentation, etc., feel free to ask


        


More information about the llvm-commits mailing list