[compiler-rt] [scudo] Handle failed mmap for allocation ring buffer (PR #71817)

via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 10:06:46 PST 2023


================
@@ -1281,7 +1281,8 @@ class Allocator {
 
   void storeSecondaryAllocationStackMaybe(const Options &Options, void *Ptr,
                                           uptr Size) {
-    if (!UNLIKELY(Options.get(OptionBit::TrackAllocationStacks)))
+    if (!UNLIKELY(Options.get(OptionBit::TrackAllocationStacks)) ||
+        RawRingBuffer == nullptr)
----------------
ChiaHungDuan wrote:

Just reviewed the logic, I may think that we may want to support turning on/off TrackAllocationStacks by env variable so that we won't have two ways to control this function. Same as above, no strong opinion here.

https://github.com/llvm/llvm-project/pull/71817


More information about the llvm-commits mailing list