[llvm] [Docs] Instructions for new contributors to find reviewers (PR #71936)

Pablo Antonio Martinez via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 10 06:49:00 PST 2023


https://github.com/pabloantoniom updated https://github.com/llvm/llvm-project/pull/71936

>From a2c094749b7bd421c8c80ac5325ef50661403c99 Mon Sep 17 00:00:00 2001
From: Pablo Antonio Martinez <pablo.antonio.martinez at huawei.com>
Date: Fri, 10 Nov 2023 13:07:40 +0000
Subject: [PATCH 1/2] [Docs] Instructions for new contributors to find
 reviewers

---
 llvm/docs/Contributing.rst | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/llvm/docs/Contributing.rst b/llvm/docs/Contributing.rst
index 2a032efa663d129..e001d35a2c5a85d 100644
--- a/llvm/docs/Contributing.rst
+++ b/llvm/docs/Contributing.rst
@@ -98,7 +98,10 @@ To make sure the right people see your patch, please select suitable reviewers
 and add them to your patch when requesting a review. Suitable reviewers are the
 code owner (see CODE_OWNERS.txt) and other people doing work in the area your
 patch touches. Github will normally suggest some reviewers based on rules or
-people that have worked on the code before.
+people that have worked on the code before. If you are a new contributor, you
+will not be able to select reviewers in such way, in which case you can still
+get the attention of potential reviewers by CC'ing them in a comment -- just
+ at name them.
 
 A reviewer may request changes or ask questions during the review. If you are
 uncertain on how to provide test cases, documentation, etc., feel free to ask

>From c34b98d3437146fb7ba44efd0c3f6a51c8c25598 Mon Sep 17 00:00:00 2001
From: Pablo Antonio Martinez <pablo.antonio.martinez at huawei.com>
Date: Fri, 10 Nov 2023 14:48:10 +0000
Subject: [PATCH 2/2] [Docs] Fix typo

---
 llvm/docs/Contributing.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/docs/Contributing.rst b/llvm/docs/Contributing.rst
index e001d35a2c5a85d..c2198924a3b3fb5 100644
--- a/llvm/docs/Contributing.rst
+++ b/llvm/docs/Contributing.rst
@@ -99,7 +99,7 @@ and add them to your patch when requesting a review. Suitable reviewers are the
 code owner (see CODE_OWNERS.txt) and other people doing work in the area your
 patch touches. Github will normally suggest some reviewers based on rules or
 people that have worked on the code before. If you are a new contributor, you
-will not be able to select reviewers in such way, in which case you can still
+will not be able to select reviewers in such a way, in which case you can still
 get the attention of potential reviewers by CC'ing them in a comment -- just
 @name them.
 



More information about the llvm-commits mailing list