[lldb] [llvm] Fix size in bytes of type DIEs when size in bits is not a multiple of 8 (PR #69741)
Michael Buch via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 9 22:33:29 PST 2023
================
@@ -2866,8 +2879,12 @@ void DWARFASTParserClang::ParseSingleMember(
// Get the parent byte size so we can verify any members will fit
const uint64_t parent_byte_size =
parent_die.GetAttributeValueAsUnsigned(DW_AT_byte_size, UINT64_MAX);
- const uint64_t parent_bit_size =
- parent_byte_size == UINT64_MAX ? UINT64_MAX : parent_byte_size * 8;
+ uint64_t parent_bit_size;
+ if (parent_byte_size != UINT64_MAX)
+ parent_bit_size = parent_byte_size * 8;
+ else
+ parent_bit_size =
+ parent_die.GetAttributeValueAsUnsigned(DW_AT_bit_size, UINT64_MAX);
----------------
Michael137 wrote:
Thoughts on extracting this block into a helper? Then you can use it above as well.
https://github.com/llvm/llvm-project/pull/69741
More information about the llvm-commits
mailing list