[llvm] Try to fix good-first-issue bot (PR #71816)

Timm Baeder via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 9 07:22:43 PST 2023


https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/71816

Shouldn't this work? Or is this only called once per label now and the entire logic has to be changed?

>From faae3b7832409ab8db80eebbeee04a3e11934c91 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?= <tbaeder at redhat.com>
Date: Thu, 9 Nov 2023 16:21:06 +0100
Subject: [PATCH] Try to fix good-first-issue bot

---
 llvm/utils/git/github-automation.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index ad1878d41193920..03844d2f200b76b 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -78,11 +78,14 @@ def run(self) -> bool:
         if not team:
             print(f"couldn't find team named {self.team_name}")
             return False
+
+        body = escape_description(self.issue.body)
+
         comment = ""
         if team.slug == "issue-subscribers-good-first-issue":
             comment = "{}\n".format(beginner_comment)
+            self.issue.create_comment(comment)
 
-        body = escape_description(self.issue.body)
 
         comment = f"""
 @llvm/{team.slug}



More information about the llvm-commits mailing list