[llvm] [CFI] Fix Direct Call Issues in CFI Dispatch Table (PR #69663)
Simon Tatham via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 9 07:16:05 PST 2023
================
@@ -1471,6 +1471,11 @@ void LowerTypeTestsModule::createJumpTable(
SmallVector<Value *, 16> AsmArgs;
AsmArgs.reserve(Functions.size() * 2);
+ // Check if the first entry has the NoUnwind attribute.
----------------
statham-arm wrote:
In that case, can you add a comment in the patch explaining all this, please? If this confused me, it will probably confuse other people reading the code, and they shouldn't have to find their way to this PR to get the explanation.
https://github.com/llvm/llvm-project/pull/69663
More information about the llvm-commits
mailing list