[PATCH] D154353: [DebugInfo][RemoveDIs] Implement behind-the-scenes debug-info maintenance in splice / moveBefore / insertBefore APIs

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Some other changes that have filtered in:

- `CodeGenPrepare::placeDbgValues` deliberately removes dbg.value intrinsics, so I've removed the assertion in `Instruction::eraseFromParent`. We're in a much stronger position wrt. binary-identicalness so I'm not worried about this.
- There are some fixes for TrailingDPValues now being stored in LLVMContextImpl, but they're all mechanical.
- Some things have been renamed / reworded as suggested.
- One of the comments in the big-comment in spliceDebugInfo was wrong, "Or if we didn't want to insert at the head of Dest"... but the example had the "head" bit set to true. I've flipped this to the correct way, but figured I'd highlight this as being deliberate rather than an accident. If we don't want to insert before dbg.values on an iterator, the "head" bit should be false.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154353/new/

https://reviews.llvm.org/D154353