[lld] [lld][MachO] Prevent doubled N_SO when comp_dir and name absolute (PR #71608)
    Shoaib Meenai via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Nov  8 14:28:39 PST 2023
    
    
  
================
@@ -1522,13 +1522,17 @@ void ObjFile::registerEhFrames(Section &ehFrameSection) {
 }
 
 std::string ObjFile::sourceFile() const {
+  const char *unitName = compileUnit->getUnitDIE().getShortName();
----------------
smeenai wrote:
I would have wondered why the logic was written this way if your commit hadn't mentioned that it was matching the check in libObject :) Could you add a code comment here pointing to that logic so that it's easy to understand why it's written this way?
https://github.com/llvm/llvm-project/pull/71608
    
    
More information about the llvm-commits
mailing list