[llvm] [NFC][AsmPrinter] Clean up stale comments (PR #71736)
Scott Linder via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 8 13:05:45 PST 2023
https://github.com/slinder1 created https://github.com/llvm/llvm-project/pull/71736
The first comment seems to have survived https://reviews.llvm.org/D4919
by accident, and no longer has any meaning.
The second is now imprecise, as more than just DBG_VALUE have already
been considered by this point in the function.
>From 30fbba91ce82b68395b0b527ff0f34d349e6a010 Mon Sep 17 00:00:00 2001
From: Scott Linder <Scott.Linder at amd.com>
Date: Wed, 8 Nov 2023 21:05:35 +0000
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?UTF-8?q?l=20version?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Created using spr 1.3.6-beta.1
---
llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp b/llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
index 55a0afcf7a33f16..dab27d209d18fd6 100644
--- a/llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
@@ -466,9 +466,6 @@ void llvm::calculateDbgEntityHistory(const MachineFunction *MF,
for (const auto &MI : MBB) {
if (MI.isDebugValue()) {
assert(MI.getNumOperands() > 1 && "Invalid DBG_VALUE instruction!");
- // Use the base variable (without any DW_OP_piece expressions)
- // as index into History. The full variables including the
- // piece expressions are attached to the MI.
const DILocalVariable *RawVar = MI.getDebugVariable();
assert(RawVar->isValidLocationForIntrinsic(MI.getDebugLoc()) &&
"Expected inlined-at fields to agree");
@@ -492,8 +489,7 @@ void llvm::calculateDbgEntityHistory(const MachineFunction *MF,
if (MI.isMetaInstruction())
continue;
- // Not a DBG_VALUE instruction. It may clobber registers which describe
- // some variables.
+ // Other instruction may clobber registers which describe some variables.
for (const MachineOperand &MO : MI.operands()) {
if (MO.isReg() && MO.isDef() && MO.getReg()) {
// Ignore call instructions that claim to clobber SP. The AArch64
More information about the llvm-commits
mailing list