[lld] [LLD][COFF] Add -build-id flag to generate .buildid section. (PR #71433)
    Martin Storsjö via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Nov  8 12:43:33 PST 2023
    
    
  
https://github.com/mstorsjo commented:
The MinGW side parts LGTM, with a few minor comments on the test.
For the COFF side (sorry for forgetting to recheck that one earlier), I think the changes are ok, but I'd appreciate if someone else who is familiar with those parts wants to have a look at those bits as well. If not I guess I can give it a second closer look.
There's some restructurings for how the different hashes/structures are made (I presume since you're not reusing the chunks but creating two separate sets, if needed) - have you checked that the output is binary identical to before (where applicable)?
https://github.com/llvm/llvm-project/pull/71433
    
    
More information about the llvm-commits
mailing list