[llvm] [CFI] Fix Direct Call Issues in CFI Dispatch Table (PR #69663)

Oskar Wirga via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 10:14:08 PST 2023


================
@@ -1471,6 +1471,11 @@ void LowerTypeTestsModule::createJumpTable(
   SmallVector<Value *, 16> AsmArgs;
   AsmArgs.reserve(Functions.size() * 2);
 
+  // Check if the first entry has the NoUnwind attribute.
----------------
oskarwirga wrote:

You raise a good point and my understanding of this issue specifically crops up when these `cfi.jumptable` functions are replaced as direct calls. AFAIK there won't be direct call replacements for dispatch tables greater than size 1, but I would like to double check to confirm this. 

https://github.com/llvm/llvm-project/pull/69663


More information about the llvm-commits mailing list