[llvm] [JITLink][AArch32] Add dynamic lookup for relocation fixup infos (PR #71649)

Stefan Gränitz via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 02:51:34 PST 2023


================
@@ -326,26 +359,16 @@ Expected<int64_t> readAddendData(LinkGraph &G, Block &B, const Edge &E) {
 Expected<int64_t> readAddendArm(LinkGraph &G, Block &B, const Edge &E) {
   ArmRelocation R(B.getContent().data() + E.getOffset());
   Edge::Kind Kind = E.getKind();
+  if (!checkOpcode(R, Kind))
+      return makeUnexpectedOpcodeError(G, R, Kind);
----------------
weliveindetail wrote:

We will get the dynamic opcode check here and get rid of the "templated" checks below. I think it significantly reduces noise and allows for much better grouping of case labels. What do you think?

https://github.com/llvm/llvm-project/pull/71649


More information about the llvm-commits mailing list