[llvm] [NewPM][CodeGen] add TargetPassConfig like API (PR #70906)

via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 02:06:16 PST 2023


paperchalice wrote:

> > Which part should run `MachineVerifier`? If in `MachinePassManager`, it can simplify the code in `CodeGenPassBuilder`. The `MachinePassManager` already has following codes:
> 
> Not sure I understand the question
> 
> > If in `CodeGenPassBuilder` then `llc` can support flags like `-stop-after=machineverifier,n`, and compatible with the old behavior.
> 
> What else would we do if not preserve this behavior?

There are several tests use `-stop-after=machineverifier` to stop after the first machine pass. if we verify machine functions in `PassInstrumentation`, we would replace `machineverifier` with a concrete pass name e.g. `early-tail-duplicate` or `local-stack-slot-allocation`, which depends on the optimization level.

https://github.com/llvm/llvm-project/pull/70906


More information about the llvm-commits mailing list