[llvm] [llvm-symbolizer] restore --[no-]use-symbol-table option (PR #71008)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 8 00:56:17 PST 2023


================
@@ -0,0 +1,219 @@
+# REQUIRES: x86-registered-target
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+# RUN: llvm-addr2line --no-use-symbol-table -fe %t.o 0x1 | FileCheck %s
+# CHECK: foo
+# CHECK: relocatable.c
+# The above addr2line command prints "b" if --use-symbol-table
----------------
jh7370 wrote:

New tests prefer `##` to distinguish test comments from actual test commands.

Also, the same coding guidelines about comments apply to code as well as to tests, i.e. here and below missing a full stop.

I think it would be useful to briefly explain the why behind the difference in behaviour.

https://github.com/llvm/llvm-project/pull/71008


More information about the llvm-commits mailing list