[llvm] TableGen support for RegisterBankInfo (PR #71357)

Pierre van Houtryve via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 23:04:29 PST 2023


================
@@ -112,7 +112,11 @@ class RegisterBankEmitter {
   void emitBaseClassDefinition(raw_ostream &OS, const StringRef TargetName,
                                const std::vector<RegisterBank> &Banks);
   void emitBaseClassImplementation(raw_ostream &OS, const StringRef TargetName,
-                                   std::vector<RegisterBank> &Banks);
+                                   const std::vector<RegisterBank> &Banks);
+  void emitRBIHeader(raw_ostream &OS, const StringRef TargetName,
+                     const std::vector<RegisterBank> &Banks);
+  void emitRBIImplementation(raw_ostream &OS, const StringRef TargetName,
+                             const std::vector<RegisterBank> &Banks);
----------------
Pierre-vh wrote:

`const StringRef` is not really needed, just use `StringRef`
extra small nit: `vector&` could be `ArrayRef` but since other functions also use a ref it's ok to stay consistent with them.

https://github.com/llvm/llvm-project/pull/71357


More information about the llvm-commits mailing list