[llvm] [XCOFF][obj2yaml] support parsing auxiliary symbols for XCOFF (PR #70642)

via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 22:35:15 PST 2023


================
@@ -131,7 +209,119 @@ Error XCOFFDumper::dumpSymbols() {
 
     Sym.Type = SymbolEntRef.getSymbolType();
     Sym.StorageClass = SymbolEntRef.getStorageClass();
-    Sym.NumberOfAuxEntries = SymbolEntRef.getNumberOfAuxEntries();
+    uint8_t NumOfAuxSym = SymbolEntRef.getNumberOfAuxEntries();
+    Sym.NumberOfAuxEntries = NumOfAuxSym;
+
+    if (NumOfAuxSym) {
+      std::vector<std::unique_ptr<XCOFFYAML::AuxSymbolEnt>> AuxEntTbl;
+      switch (Sym.StorageClass) {
+      case XCOFF::C_FILE: {
+        for (uint8_t I = 1; I <= NumOfAuxSym; ++I) {
----------------
EsmeYi wrote:

I didn't fully catch your comments before and sorry about it. Now the whole case body is pulled out into a separate function instead of partial codes.

https://github.com/llvm/llvm-project/pull/70642


More information about the llvm-commits mailing list