[PATCH] D71392: [AMDGPU] AMDGPUUsage clarify address space information and other typo and formatting fixes

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 16:16:08 PST 2023


t-tye added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:331
+     ================================= =============== =========== ================ ======= ============================
+     ..                                                                                     64-Bit Process Address Space
+     --------------------------------- --------------- ----------- ---------------- ------------------------------------
----------------
foad wrote:
> What is the text "64-Bit Process Address Space" supposed to mean here? Is it some kind of column heading? Is it just a mistake?
It looks like it is a heading for both the "Address Size" and "NULL Value" columns. Both those columns provide information about address spaces on AMDGPU hardware which uses a 64 bit virtual address space. Not sure if it really adds any extra meaning or could be dropped.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71392/new/

https://reviews.llvm.org/D71392



More information about the llvm-commits mailing list