[llvm] [NFC][InstrProf]Refactor readPGOFuncNameStrings (PR #71566)

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 10:36:25 PST 2023


================
@@ -469,14 +464,14 @@ class InstrProfSymtab {
   /// until before it is used. See also \c create(StringRef) method.
   Error create(object::SectionRef &Section);
 
-  /// This interface is used by reader of CoverageMapping test
-  /// format.
-  inline Error create(StringRef D, uint64_t BaseAddr);
-
   /// \c NameStrings is a string composed of one of more sub-strings
   ///  encoded in the format described in \c collectPGOFuncNameStrings.
   /// This method is a wrapper to \c readPGOFuncNameStrings method.
-  inline Error create(StringRef NameStrings);
+  Error create(StringRef NameStrings);
+
+  /// This interface is used by reader of CoverageMapping test
+  /// format.
+  inline Error create(StringRef D, uint64_t BaseAddr);
----------------
david-xl wrote:

Is this function missing?

https://github.com/llvm/llvm-project/pull/71566


More information about the llvm-commits mailing list