[compiler-rt] 8a220b2 - Disable UBSan vptr tests on Android.

Mitch Phillips via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 7 07:35:45 PST 2023


Author: Mitch Phillips
Date: 2023-11-07T16:34:36+01:00
New Revision: 8a220b229e86f42088a25424030b7b0b2bfb90c7

URL: https://github.com/llvm/llvm-project/commit/8a220b229e86f42088a25424030b7b0b2bfb90c7
DIFF: https://github.com/llvm/llvm-project/commit/8a220b229e86f42088a25424030b7b0b2bfb90c7.diff

LOG: Disable UBSan vptr tests on Android.

Unclear what's going on here. I can reproduce the test failure at
https://lab.llvm.org/buildbot/#/builders/77/builds/31875 and well before
it as well.

Doesn't look like the device has changed, and I can also repro the
problem on Android 11 and Android 14. Disabling until further notice.

Added: 
    

Modified: 
    compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-non-unique-typeinfo.cpp
    compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-virtual-base-construction.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-non-unique-typeinfo.cpp b/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-non-unique-typeinfo.cpp
index 604d0d6232bf928..76be179fc4a172b 100644
--- a/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-non-unique-typeinfo.cpp
+++ b/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-non-unique-typeinfo.cpp
@@ -3,7 +3,8 @@
 // RUN: %run %t
 //
 // REQUIRES: cxxabi
-// UNSUPPORTED: target={{.*windows.*}}
+// FIXME: Should pass on Android, but started failing around 2023-11-05 for unknown reasons.
+// UNSUPPORTED: target={{.*(windows|android).*}}
 
 struct X {
   virtual ~X() {}

diff  --git a/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-virtual-base-construction.cpp b/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-virtual-base-construction.cpp
index 37055ba1f70ebf6..7165cf317595a3b 100644
--- a/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-virtual-base-construction.cpp
+++ b/compiler-rt/test/ubsan/TestCases/TypeCheck/vptr-virtual-base-construction.cpp
@@ -2,7 +2,8 @@
 // RUN: %run %t
 
 // REQUIRES: cxxabi
-// UNSUPPORTED: target={{.*windows-msvc.*}}
+// FIXME: Should pass on Android, but started failing around 2023-11-05 for unknown reasons.
+// UNSUPPORTED: target={{.*(windows-msvc|android).*}}
 
 int volatile n;
 


        


More information about the llvm-commits mailing list